Skip to content

chore: updating path for coverage #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2021
Merged

Conversation

alan-churley
Copy link
Contributor

@alan-churley alan-churley commented Mar 16, 2021

Issue #, if available:

Description of changes:

Updating the PR test workflow to include the logger coverage report, going forward we will need to decide if we want to run all the tests separately for each package and merge/collect the reports, or if we want to run a full test suite. I think the former would be better.

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@github-actions
Copy link
Contributor

Total Coverage: 80.15%

Coverage Report
File Branch Funcs Lines Uncovered Lines
src
   Logger.ts 62.12% 90.32% 74.70% 100, 104, 105, 134, 156, 157, 164, 165, 172, 173, 180, 184, 206, 218, 222, 246, 247, 272, 277, 278, 278, 278, 278, 278, 278, 279, 282, 50, 50, 50, 51, 54, 62, 68, 69, 73, 74, 80, 81, 87, 88, 94, 94, 94, 95, 97
   index.ts 100% 100% 100%
src/config
   ConfigService.ts 100% 100% 100%
   EnvironmentVariablesService.ts 66.67% 75% 80% 25, 27, 31, 35, 49, 49
   index.ts 100% 100% 100%
src/formatter
   LogFormatter.ts 100% 100% 100%
   PowertoolLogFormatter.ts 100% 100% 100%
   index.ts 100% 100% 100%
src/log
   LogItem.ts 100% 75% 85.71% 20
   index.ts 100% 100% 100%

Copy link
Contributor

@saragerion saragerion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (and thanks!)

@alan-churley alan-churley merged commit 8abcf3f into main Mar 24, 2021
@alan-churley alan-churley deleted the chore/collect_coverage branch March 24, 2021 15:14
@heitorlessa heitorlessa added the internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) label Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants