-
Notifications
You must be signed in to change notification settings - Fork 153
docs: refresh SAM examples #1180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have left some comments, great work so far - I think we are getting very close!
Tests is failing because the AWS SAM CLI that is present in the OS used by the CI is not the latest ( We have two options here:
Looking at the releases in the repo that maintains the images it seems that a new version that includes the latest SAM CLI is already available in pre-release. I'm not aware of their release schedule and from past releases I couldn't infer any. I have opened a discussion to ask the question here, I would suggest to wait till Friday and reconvene. If by then we don't have the new version we'll set the explicit version and merge. |
@awslabs/aws-lambda-powertools-typescript No related issues found. Please ensure 'status/pending-release' label is applied before releasing. |
Description of your changes
See #1140 for details
How to verify this change
Test the SAM examples
Related issues, RFCs
Issue Number: #1140
PR status
Is this ready for review?: YES
Is it a breaking change?: NO
Checklist
Breaking change checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.