Skip to content

docs: refresh SAM examples #1180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Dec 19, 2022
Merged

Conversation

bpauwels
Copy link
Contributor

@bpauwels bpauwels commented Nov 21, 2022

Description of your changes

See #1140 for details

How to verify this change

Test the SAM examples

Related issues, RFCs

Issue Number: #1140

PR status

Is this ready for review?: YES
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding changes to the examples
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published
  • The PR title follows the conventional commit semantics

Breaking change checklist

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pull-request-size pull-request-size bot added the size/XL PRs between 500-999 LOC, often PRs that grown with feedback label Nov 21, 2022
@github-actions github-actions bot added do-not-merge This item should not be merged need-issue This PR needs an issue before it can be reviewed/worked on further labels Nov 22, 2022
@dreamorosi dreamorosi changed the title Issue 1140 - Maintenance: Refresh SAM examples docs: refresh SAM examples Nov 22, 2022
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 22, 2022
@dreamorosi dreamorosi removed do-not-merge This item should not be merged need-issue This PR needs an issue before it can be reviewed/worked on further labels Nov 22, 2022
@dreamorosi dreamorosi linked an issue Nov 22, 2022 that may be closed by this pull request
18 tasks
@aws-powertools aws-powertools deleted a comment from github-actions bot Nov 22, 2022
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left some comments, great work so far - I think we are getting very close!

@dreamorosi
Copy link
Contributor

Tests is failing because the AWS SAM CLI that is present in the OS used by the CI is not the latest (1.60.0 - source). Node 18 support was introduced in version 1.65.0 (source).

We have two options here:

  1. Use the setup-sam GitHub Action to explicitly set the version of the CLI, which would allow us to use the latest version.
  2. Wait until the base image used in the CD updates the version.

Looking at the releases in the repo that maintains the images it seems that a new version that includes the latest SAM CLI is already available in pre-release. I'm not aware of their release schedule and from past releases I couldn't infer any.

I have opened a discussion to ask the question here, I would suggest to wait till Friday and reconvene. If by then we don't have the new version we'll set the explicit version and merge.

@dreamorosi dreamorosi merged commit 95b40d1 into aws-powertools:main Dec 19, 2022
@github-actions
Copy link
Contributor

@awslabs/aws-lambda-powertools-typescript No related issues found. Please ensure 'status/pending-release' label is applied before releasing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation size/XL PRs between 500-999 LOC, often PRs that grown with feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: Refresh SAM examples
2 participants