Skip to content

fix(build): remove leftover code in action that labels issues on merge #1078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2022

Conversation

dreamorosi
Copy link
Contributor

Description of your changes

At the moment, the workflow that is run every time a PR is merged attempts to label the issue related to that PR with a pending-release tag, to inform the person opening the issue that a change will be released soon.

At the moment the script that is run during this action has a bug coming from a leftover version of the script that makes it fail.

image

This PR aims at fixing the issue.

How to verify this change

Observe the result of the "On PR Merge" workflow at the next PR merged.

Related issues, RFCs

Issue number: #1076

PR status

Is this ready for review?: YES
Is it a breaking change?: NO

Checklist

Breaking change checklist

N/A


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dreamorosi dreamorosi added automation This item relates to automation internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) labels Aug 24, 2022
@dreamorosi dreamorosi self-assigned this Aug 24, 2022
@dreamorosi dreamorosi linked an issue Aug 24, 2022 that may be closed by this pull request
@github-actions github-actions bot added the bug Something isn't working label Aug 24, 2022
@dreamorosi dreamorosi requested review from ijemmy, saragerion and flochaz and removed request for saragerion August 24, 2022 17:49
@dreamorosi dreamorosi merged commit 2b62d78 into main Aug 29, 2022
@dreamorosi dreamorosi deleted the 1076-bug-build-label-issue-on-merge-fails branch August 29, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation bug Something isn't working internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: label issue on merge fails
3 participants