Skip to content

chore(build): update make-release.yml to remove redundant publish step #1075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2022

Conversation

dreamorosi
Copy link
Contributor

Description of your changes

In #1066 we decoupled the release to NPM & docs publishing processes. With that change the release of a new Powertools for TypeScript version works as follows:

  • Manually trigger the "Make release" workflow - this will run unit tests, increase the version of the packages in the repo, create a new git tag, & publish the packages to NPM with increased version
  • Manually make a release via GitHub releases UI - this will be using the tag created earlier, and once published it will trigger the other workflow that publishes the docs using the correct version number

With this PR I'm removing a leftover step from the "Make Release" workflow that was also publishing the docs.

How to verify this change

Run the "Make release" workflow.

Related issues, RFCs

Issue number: #1063

PR status

Is this ready for review?: YES
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published in downstream module
  • The PR title follows the conventional commit semantics

Breaking change checklist

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dreamorosi dreamorosi self-assigned this Aug 24, 2022
@dreamorosi dreamorosi added automation This item relates to automation internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) labels Aug 24, 2022
@heitorlessa heitorlessa self-requested a review August 25, 2022 08:23
@heitorlessa
Copy link
Contributor

heitorlessa commented Aug 25, 2022

looking into later in the afternoon or first thing tomorrow morning. @dreamorosi pinged sharing that it can wait until everyone else is back

@dreamorosi dreamorosi merged commit 14a838f into main Aug 26, 2022
@dreamorosi dreamorosi deleted the dreamorosi-patch-1 branch August 26, 2022 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants