Skip to content

Maintenance: release process not updating package-lock.json for examples after bumping deps #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
flochaz opened this issue Jan 21, 2022 · 2 comments
Closed

Maintenance: release process not updating package-lock.json for examples after bumping deps #494

flochaz opened this issue Jan 21, 2022 · 2 comments
Assignees
@flochaz
Labels
automation This item relates to automation completed This item is complete and has been merged/shipped help-wanted We would really appreciate some support from community for this one internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)

Comments

@flochaz
Copy link
Contributor

flochaz commented Jan 21, 2022 •
edited
Loading

Bug description

package.json not matching package-lock.json after bump

Expected Behavior

lerna version should bump package.json and package-lock.json

Current Behavior

Build failing https://github.com/awslabs/aws-lambda-powertools-typescript/runs/4895012434?check_suite_focus=true

Possible Solution

Steps to Reproduce

Environment

  • Powertools version used:
  • Packaging format (Layers, npm):
  • AWS Lambda function runtime:
  • Debugging logs:

Related issues, RFCs
@flochaz flochaz added bug Something isn't working triage This item has not been triaged by a maintainer, please wait labels Jan 21, 2022
@flochaz flochaz self-assigned this Jan 21, 2022
This was referenced Jan 21, 2022
Merged
Merged
@saragerion saragerion added this to the production-ready-release milestone Jan 27, 2022
@dreamorosi dreamorosi added help-wanted We would really appreciate some support from community for this one internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) and removed triage This item has not been triaged by a maintainer, please wait labels Feb 28, 2022
@dreamorosi
Copy link
Contributor

@flochaz is this still happening? Just wanted to make sure the issue is not stale.

@saragerion saragerion removed this from the production-ready-release milestone May 16, 2022
@flochaz flochaz closed this as completed May 18, 2022
@github-actions
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@dreamorosi dreamorosi added automation This item relates to automation completed This item is complete and has been merged/shipped and removed bug Something isn't working labels Nov 14, 2022
@dreamorosi dreamorosi changed the title chore(cicd): release process not updating package-lock.json for examples after bumping deps Maintenance: release process not updating package-lock.json for examples after bumping deps Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flochaz flochaz

Labels
automation This item relates to automation completed This item is complete and has been merged/shipped help-wanted We would really appreciate some support from community for this one internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@flochaz @dreamorosi @saragerion