Skip to content

Maintenance: lerna version is bumping dependencies as well #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
flochaz opened this issue Jan 14, 2022 · 2 comments
Closed

Maintenance: lerna version is bumping dependencies as well #468

flochaz opened this issue Jan 14, 2022 · 2 comments
Assignees
Labels
automation This item relates to automation completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)

Comments

@flochaz
Copy link
Contributor

flochaz commented Jan 14, 2022

Bug description

On lerna version (https://github.com/awslabs/aws-lambda-powertools-typescript/blob/main/.github/workflows/on-release-prod.yml#L44) lerna bump all packages to new version in package.json and package-lock.json but bump as well @aws-lambda-powertools/commons in our module package (https://github.com/awslabs/aws-lambda-powertools-typescript/blob/main/packages/metrics/package.json#L87) event with put strict version due this lerna/lerna#2326 .

Expected Behavior

I would expect lerna to not touch my dependencies or at least update package-lock.json properly ....

Current Behavior

lerna bump dependencies as well

Possible Solution

Not sure yet

Steps to Reproduce

run npx lerna version --conventional-commits --conventional-graduate --force-publish=* --yes --no-git-tag-version --no-push

npm run lerna-ci will fail

Environment

  • Powertools version used: 0.3.0
  • Packaging format (Layers, npm): -
  • AWS Lambda function runtime: -
  • Debugging logs:
➜  aws-lambda-powertools-typescript git:(main) npm run lerna-ci

> [email protected] lerna-ci
> lerna exec -- npm ci

lerna notice cli v4.0.0
lerna info Executing command in 4 packages: "npm ci"
npm WARN prepare removing existing node_modules/ before installation

> @aws-lambda-powertools/[email protected] prepare /Users/chazalf/amazon/PowerTool/aws-lambda-powertools-typescript/packages/commons
> npm run build


> @aws-lambda-powertools/[email protected] build /Users/chazalf/amazon/PowerTool/aws-lambda-powertools-typescript/packages/commons
> tsc

added 574 packages in 13.871s
npm WARN prepare removing existing node_modules/ before installation
npm WARN prepare removing existing node_modules/ before installation
npm WARN prepare removing existing node_modules/ before installation
npm ERR! cipm can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with `npm install` before continuing.
@flochaz flochaz added bug Something isn't working triage This item has not been triaged by a maintainer, please wait labels Jan 14, 2022
@dreamorosi
Copy link
Contributor

Can we close this after #470 has been merged?

@github-actions
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@dreamorosi dreamorosi removed the triage This item has not been triaged by a maintainer, please wait label Oct 19, 2022
@dreamorosi dreamorosi added automation This item relates to automation internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) completed This item is complete and has been merged/shipped and removed bug Something isn't working labels Nov 14, 2022
@dreamorosi dreamorosi changed the title bug(cicd): lerna version is bumping dependencies as well Maintenance: lerna version is bumping dependencies as well Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Projects
None yet
Development

No branches or pull requests

2 participants