Skip to content

Maintenance: Make @middy/core a devDependency #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks
dreamorosi opened this issue Dec 30, 2021 · 2 comments · Fixed by #511
Closed
2 tasks

Maintenance: Make @middy/core a devDependency #373

dreamorosi opened this issue Dec 30, 2021 · 2 comments · Fixed by #511
Assignees
Labels
completed This item is complete and has been merged/shipped dependencies Changes that touch dependencies, e.g. Dependabot, etc.

Comments

@dreamorosi
Copy link
Contributor

Description of the feature request

Problem statement

Middy (@middy/core) is currently used in the middlewares implementations only for types (as brought up by @saragerion here).

We should move it as devDependency to avoid bundling it to Customers who might not be using it.

  • Move @middy/core to devDependencies for all packages
  • Update notices in utilities docs to specify that customers who want to use the middleware must install it

Summary of the feature

N/A

Code examples

N/A

Benefits for you and the wider AWS community

Avoid including unnecessary dependencies for those who don't use middy middlewares.

Describe alternatives you've considered

N/A

Additional context

N/A

Related issues, RFCs

#370

@dreamorosi dreamorosi added the triage This item has not been triaged by a maintainer, please wait label Dec 30, 2021
@dreamorosi dreamorosi added this to the production-ready-release milestone Dec 30, 2021
@dreamorosi dreamorosi added all dependencies Changes that touch dependencies, e.g. Dependabot, etc. labels Dec 30, 2021
@michaelbrewer
Copy link
Contributor

Thanks @dreamorosi for adding this.

@github-actions
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@dreamorosi dreamorosi removed the triage This item has not been triaged by a maintainer, please wait label Oct 19, 2022
@dreamorosi dreamorosi changed the title (all): Make middy/core a devDependency Maintenance: Make @middy/core a devDependency Nov 14, 2022
@dreamorosi dreamorosi added the completed This item is complete and has been merged/shipped label Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed This item is complete and has been merged/shipped dependencies Changes that touch dependencies, e.g. Dependabot, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants