Skip to content

feat(ci): Add advanced automation #3438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 7, 2025
Merged

feat(ci): Add advanced automation #3438

merged 5 commits into from
Feb 7, 2025

Conversation

sthulb
Copy link
Contributor

@sthulb sthulb commented Dec 20, 2024

Summary

Changes

Please provide a summary of what's being changed

This PR adds the ability to bootstrap new regions and create SSM parameters to alias Lambda Layer ARNs.

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: #3200, #3439


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@sthulb sthulb requested a review from a team December 20, 2024 13:27
@sthulb sthulb requested a review from a team as a code owner December 20, 2024 13:27
@boring-cyborg boring-cyborg bot added the automation This item relates to automation label Dec 20, 2024
@pull-request-size pull-request-size bot added the size/L PRs between 100-499 LOC label Dec 20, 2024
@github-actions github-actions bot added feature PRs that introduce new features or minor changes labels Dec 20, 2024
Copy link
Contributor

No related issues found. Please ensure there is an open issue related to this change to avoid significant delays or closure.

Copy link
Contributor

No acknowledgement section found. Please make sure you used the template to open a PR and didn't remove the acknowledgment section. Check the template here: https://github.com/aws-powertools/powertools-lambda-typescript/blob/develop/.github/PULL_REQUEST_TEMPLATE.md#acknowledgment

@github-actions github-actions bot added do-not-merge This item should not be merged need-issue This PR needs an issue before it can be reviewed/worked on further labels Dec 20, 2024
@dreamorosi dreamorosi removed the need-issue This PR needs an issue before it can be reviewed/worked on further label Jan 22, 2025
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update - I just want to make sure we're using the CDK version from the project, so we can be sure that it'll work since we're already using it in other workflows.

Other than that, assuming we have no way to test this or it has already been tested elsewhere - is there a way to make the update_ssm one part of the release workflow?

Or should we keep it as a manual step? If yes, why?

@dreamorosi dreamorosi removed the do-not-merge This item should not be merged label Feb 6, 2025
Copy link

sonarqubecloud bot commented Feb 7, 2025

@dreamorosi dreamorosi self-requested a review February 7, 2025 16:21
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still would have preferred to use the CDK version in the project rather than pinning it, like we discussed, but I also want to move forward and close this PR.

If the OpenSSF Scorecard complains I'll make another commit do it.

@dreamorosi dreamorosi removed the request for review from leandrodamascena February 7, 2025 16:22
@dreamorosi dreamorosi merged commit 4e9ff07 into main Feb 7, 2025
39 checks passed
@dreamorosi dreamorosi deleted the automation branch February 7, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation feature PRs that introduce new features or minor changes size/L PRs between 100-499 LOC
Projects
Development

Successfully merging this pull request may close these issues.

3 participants