-
Notifications
You must be signed in to change notification settings - Fork 153
Maintenance: update bootstrap region automation to remove pinned/aliased dependencies #3573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This issue is now closed. Please be mindful that future comments are hard for our team to see. If you need more assistance, please either tag a team member or open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so. |
Reopening because the changes fixed only one of the two. The https://github.com/aws-powertools/powertools-lambda-typescript/security/code-scanning/77 one is still open. @sthulb could you please help me understand where is the hash missing? Please don't just dismiss it, thank you. |
After discussing w/ @sthulb he explained that the finding is complaining about us not having a lock file for the Go dependency. However since we are installing it with the commit hash of the source repo, it's already immutable. Because of this, it's safe to dismiss since we control both this repo and the source of the pkg (aws-powertools/actions) |
This issue is now closed. Please be mindful that future comments are hard for our team to see. If you need more assistance, please either tag a team member or open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so. |
Summary
Some of the changes introduced in #3438 lowered our OpenSSF Scorecard due to both pinned dependencies and actions using the
latest
tag instead of a commit hash.Specifically, the two are:
Which correspond to these two alerts:
Note that neither of them involves code that we ship to customers, this is only automation used for us to bootstrap new regions we use to deploy resources.
Why is this needed?
So we can restore our OpenSSF Scorecard score.
Which area does this relate to?
Other
Solution
The first should use a commit hash, similar to what we do here.
The second one should use the CDK version already present in the monorepo rather than install a different one.
Acknowledgment
Future readers
Please react with 👍 and your use case to help us understand customer demand.
The text was updated successfully, but these errors were encountered: