feat(logger): change visibility to protected

[zirkelc]

Summary

Change the visibility of Logger methods from private to protected to allow subclassing of Logger to add new functionaility

Changes

Please provide a summary of what's being changed

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: #3376

---

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

[dreamorosi]

I see that you changed more methods and properties than the ones we discussed in #3376.

I would be inclined to stick to the initial plan and revert the other changes, or if the initial list of methods discussed are not enough to cover your use case, close the PR and invest time in shipping the feature for everyone within the boundaries of the public API.

The reason why we're reticent with making everything accessible is that we don't want to create the false expectation that all these methods/properties are there to stay.

Our commitment to avoiding breaking changes extends exclusively to public methods. Any other method or property is to be considered internal for all intents and purposes.

This is also why we're gradually moving away from private and have started using actual JavaScript private fields (i.e. private getLogLevelNameFromNumber() becomes #getLogLevelNameFromNumber()).

[zirkelc]

I changed the additional methods/properties back to private, please have a look.

There is one optional comment about this.console: it would be useful to have this accessible from subclasses, but it's not required. I can work around that.

[dreamorosi]

Thank you for addressing my comments.

Looking forward to collaborating on the RFC!

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud