-
Notifications
You must be signed in to change notification settings - Fork 153
Feature Request: add support for Middy.js 6.x #3367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for opening your first issue here! We'll come back to you as soon as we can. |
Hi, thank you for opening this issue. This is intentional, and also not a bug. Powertools for AWS is officially compatible only with v4.x and v5.x as of now, as stated in our docs. Middy.js v6.x was released recently and we haven't yet added automated tests to ensure it's compatible, this is why the peer dependency version range doesn't include the new version. I'm going to convert this to a feature request and put it in the backlog. |
Thanks for the update. I have created a PR that runs test for middy 4, 5, 6 but I appreciate that you might want further tests or investigations on it |
This issue is now closed. Please be mindful that future comments are hard for our team to see. If you need more assistance, please either tag a team member or open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so. |
@dreamorosi out of curiosity, when is the next release planned with this change 🙃 ? |
Hey @WtfJoke, sorry for the delay. The team has been busy for re:Invent and we skipped a release week last week. I am planning on making a release early next week on Monday/Tuesday at the latest. Thank you for your patience, and sorry for the inconvenience. |
No worries! Take your time for the release. Thank you for the fast answer. |
This is now released under v2.12.0 version! |
@dreamorosi and team, thank you for the release 🙌 |
Expected Behavior
You can install v6.x of @middy/core and @aws-lambda-powertools/logger
Current Behavior
When installing v6.x of @middy/core you get this error
Code snippet
in package.json
Steps to Reproduce
Install @middy/core v6 and @aws-lambda-powertools/logger
Possible Solution
change peerDepenedencies in @aws-lambda-powertools/logger to include v6 of @middy/core
Powertools for AWS Lambda (TypeScript) version
latest
AWS Lambda function runtime
22.x
Packaging format used
npm
Execution logs
The text was updated successfully, but these errors were encountered: