Skip to content

Maintenance: add typedoc-plugin-missing-exports plugin to remove missing exports warnings #2993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 2 tasks
am29d opened this issue Aug 29, 2024 · 3 comments · Fixed by #3000
Closed
1 of 2 tasks
Assignees
Labels
completed This item is complete and has been merged/shipped documentation Improvements or additions to documentation internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)

Comments

@am29d
Copy link
Contributor

am29d commented Aug 29, 2024

Summary

While cleaning up the api docs in one of the issues of #2381 the typedoc complains about resources that are references but not exported. While we can add them to exports to fix it, I found a better solution to add these missing resources to the doc, without exposing them.

https://github.com/Gerrit0/typedoc-plugin-missing-exports

Also saw, just now that we have this plugin already installed in the package.json, but we did not add it typedoc configuration.

This plugin collects all the missing exports we reference but still don't want to export.

Why is this needed?

So we don't have to export types, classes and functions that are internal just to have them in the API docs.

Which area does this relate to?

Other

Solution

Add https://github.com/Gerrit0/typedoc-plugin-missing-exports plugin your package script npm run docs-generateApiDoc. In addition, I would also revert the changes we have made in the recent PRs to fix the warnings.

Alternatively we can mute those warnings, but the information about the internal interfaces, classes and functions will not be available in the API docs, which I would prefer to have.

Acknowledgment

Future readers

Please react with 👍 and your use case to help us understand customer demand.

@am29d am29d added triage This item has not been triaged by a maintainer, please wait internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) labels Aug 29, 2024
@am29d am29d self-assigned this Aug 29, 2024
@am29d am29d added documentation Improvements or additions to documentation confirmed The scope is clear, ready for implementation and removed triage This item has not been triaged by a maintainer, please wait labels Aug 29, 2024
@am29d am29d moved this from Triage to Working on it in Powertools for AWS Lambda (TypeScript) Aug 29, 2024
@dreamorosi
Copy link
Contributor

Good find, I agree we should enable it.

It must have been unintentionally dropped when we did the v2 merge (probably my bad).

Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added pending-release This item has been merged and will be released soon and removed confirmed The scope is clear, ready for implementation labels Aug 30, 2024
Copy link
Contributor

This is now released under v2.8.0 version!

@github-actions github-actions bot added completed This item is complete and has been merged/shipped and removed pending-release This item has been merged and will be released soon labels Sep 16, 2024
@dreamorosi dreamorosi moved this from Coming soon to Shipped in Powertools for AWS Lambda (TypeScript) Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed This item is complete and has been merged/shipped documentation Improvements or additions to documentation internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Projects
2 participants