Skip to content

Maintenance: remove duplication in Idempotency tests #2918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 of 2 tasks
dreamorosi opened this issue Aug 13, 2024 · 2 comments · Fixed by #2919
Closed
1 of 2 tasks

Maintenance: remove duplication in Idempotency tests #2918

dreamorosi opened this issue Aug 13, 2024 · 2 comments · Fixed by #2919
Assignees
@dreamorosi
Labels
completed This item is complete and has been merged/shipped idempotency This item relates to the Idempotency Utility internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) tests PRs that add or change tests

Comments

@dreamorosi
Copy link
Contributor

Summary

The unit tests for the makeIdempotent function wrapper and the makeHandlerIdempotent Middy.js middleware are very similar except for some lines.

According to SonarCloud, the two test files have 68% of duplication. We should work to reduce this to a minimum.

Why is this needed?

So that we can drop redundant code and reduce maintenance burden and cognitive load for maintainers and contributors.

Which area does this relate to?

Tests

Solution

No response

Acknowledgment

Future readers

Please react with 👍 and your use case to help us understand customer demand.
@dreamorosi dreamorosi added internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) idempotency This item relates to the Idempotency Utility confirmed The scope is clear, ready for implementation tests PRs that add or change tests labels Aug 13, 2024
@dreamorosi dreamorosi self-assigned this Aug 13, 2024
@dreamorosi dreamorosi mentioned this issue Aug 13, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added pending-release This item has been merged and will be released soon and removed confirmed The scope is clear, ready for implementation labels Aug 13, 2024
@dreamorosi dreamorosi mentioned this issue Aug 19, 2024
Open
@github-actions GitHub Actions
Copy link
Contributor

This is now released under v2.8.0 version!

@github-actions github-actions bot added completed This item is complete and has been merged/shipped and removed pending-release This item has been merged and will be released soon labels Sep 16, 2024
@dreamorosi dreamorosi moved this from Coming soon to Shipped in Powertools for AWS Lambda (TypeScript) Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dreamorosi dreamorosi

Labels
completed This item is complete and has been merged/shipped idempotency This item relates to the Idempotency Utility internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) tests PRs that add or change tests
Projects
Powertools for AWS Lambda (TypeScript)
Status: Shipped
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(idempotency): simplify wrapper & middleware tests aws-powertools/powertools-lambda-typescript
1 participant
@dreamorosi