Skip to content

Maintenance: initialise SDK client only when needed in Idempotency #1767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 of 2 tasks
dreamorosi opened this issue Oct 30, 2023 · 2 comments · Fixed by #1768
Closed
1 of 2 tasks

Maintenance: initialise SDK client only when needed in Idempotency #1767

dreamorosi opened this issue Oct 30, 2023 · 2 comments · Fixed by #1768
Assignees
@dreamorosi
Labels
completed This item is complete and has been merged/shipped idempotency This item relates to the Idempotency Utility internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)

Comments

@dreamorosi
Copy link
Contributor

Summary

In #1757 we have refactored the logic that initializes the AWS SDK client needed in the Parameters utility so that it's executed only when a customer doesn't pass us a client. The Idempotency utility could benefit from a similar optimization as it uses the same logic that was found in the Parameters utility before the refactor.

Why is this needed?

This avoids adding unnecessary runtime cost to the execution for those customers who are providing their own AWS SDK client.

Which area does this relate to?

Idempotency

Solution

Apply the same logic as the one applied in the Parameters utility in #1757.

Acknowledgment

Future readers

Please react with 👍 and your use case to help us understand customer demand.
@dreamorosi dreamorosi added internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) idempotency This item relates to the Idempotency Utility confirmed The scope is clear, ready for implementation labels Oct 30, 2023
@dreamorosi dreamorosi self-assigned this Oct 30, 2023
@dreamorosi dreamorosi mentioned this issue Oct 30, 2023
Merged
9 tasks
@dreamorosi dreamorosi linked a pull request Oct 30, 2023 that will close this issue
chore(idempotency): refactor aws sdk init logic #1768
Merged
9 tasks
@github-project-automation github-project-automation bot moved this from Working on it to Coming soon in Powertools for AWS Lambda (TypeScript) Oct 30, 2023
@github-actions
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added pending-release This item has been merged and will be released soon and removed confirmed The scope is clear, ready for implementation labels Oct 30, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2023

This is now released under v1.14.1 version!

@github-actions github-actions bot added completed This item is complete and has been merged/shipped and removed pending-release This item has been merged and will be released soon labels Nov 1, 2023
@dreamorosi dreamorosi moved this from Coming soon to Shipped in Powertools for AWS Lambda (TypeScript) Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dreamorosi dreamorosi

Labels
completed This item is complete and has been merged/shipped idempotency This item relates to the Idempotency Utility internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Projects
Powertools for AWS Lambda (TypeScript)
Status: Shipped
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(idempotency): refactor aws sdk init logic aws-powertools/powertools-lambda-typescript
1 participant
@dreamorosi