Skip to content

Feature request: Add back Idempotent decorators #1700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 2 tasks
HaaLeo opened this issue Sep 21, 2023 · 5 comments · Fixed by #1723
Closed
1 of 2 tasks

Feature request: Add back Idempotent decorators #1700

HaaLeo opened this issue Sep 21, 2023 · 5 comments · Fixed by #1723
Assignees
Labels
completed This item is complete and has been merged/shipped feature-request This item refers to a feature request for an existing or new utility idempotency This item relates to the Idempotency Utility

Comments

@HaaLeo
Copy link
Contributor

HaaLeo commented Sep 21, 2023

Use case

I want to annotate class methods with a decorator.
Example:

export class Foo {
  @MakeIdempotent(config)
  public submitPayment(): void {
    // Do something
  }
}

Since the package now is based on typescript 5.x (#1375) I'd assume this should not be a problem.

Solution/User Experience

Add the decorators back in which have been removed with #1553

Alternative solutions

No response

Acknowledgment

Future readers

Please react with 👍 and your use case to help us understand customer demand.

@HaaLeo HaaLeo added triage This item has not been triaged by a maintainer, please wait feature-request This item refers to a feature request for an existing or new utility labels Sep 21, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Sep 21, 2023

Thanks for opening your first issue here! We'll come back to you as soon as we can.
In the meantime, check out the #typescript channel on our Powertools for AWS Lambda Discord: Invite link

@am29d
Copy link
Contributor

am29d commented Sep 21, 2023

Hey @HaaLeo again 🙂

thanks a lot for the feedback and raising these points. As you pointed out, we have waited for TypeScript 5.x migration so we know the decorator interface. Now we can add this feature, that will also be available in the layer 👍 .

Best
Alex

@am29d am29d self-assigned this Sep 21, 2023
@am29d am29d added idempotency This item relates to the Idempotency Utility and removed triage This item has not been triaged by a maintainer, please wait labels Sep 21, 2023
@am29d am29d moved this from Backlog to Working on it in Powertools for AWS Lambda (TypeScript) Sep 25, 2023
@dreamorosi
Copy link
Contributor

Hi @HaaLeo, we have merged the PR that adds the Idempotency utility to the Layer and we plan on making a release during the week.

We will need a bit more time to implement the decorators for the utility so it's likely going to come in a future release.

@dreamorosi dreamorosi added the confirmed The scope is clear, ready for implementation label Sep 26, 2023
@github-project-automation github-project-automation bot moved this from Working on it to Coming soon in Powertools for AWS Lambda (TypeScript) Sep 28, 2023
@github-actions
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added pending-release This item has been merged and will be released soon and removed confirmed The scope is clear, ready for implementation labels Sep 28, 2023
@dreamorosi dreamorosi reopened this Sep 28, 2023
@github-actions
Copy link
Contributor

This is now released under v1.14.0 version!

@github-actions github-actions bot added completed This item is complete and has been merged/shipped and removed pending-release This item has been merged and will be released soon labels Sep 29, 2023
@dreamorosi dreamorosi moved this from Coming soon to Shipped in Powertools for AWS Lambda (TypeScript) Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed This item is complete and has been merged/shipped feature-request This item refers to a feature request for an existing or new utility idempotency This item relates to the Idempotency Utility
Projects
Development

Successfully merging a pull request may close this issue.

3 participants