Skip to content

Maintenance: remove Idempotency decorators #1553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 2 tasks
dreamorosi opened this issue Jun 26, 2023 · 2 comments · Fixed by #1554
Closed
1 of 2 tasks

Maintenance: remove Idempotency decorators #1553

dreamorosi opened this issue Jun 26, 2023 · 2 comments · Fixed by #1554
Assignees
Labels
completed This item is complete and has been merged/shipped idempotency This item relates to the Idempotency Utility internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)

Comments

@dreamorosi
Copy link
Contributor

Summary

The current pre-release version of the Idempotency utility includes decorators that allow to make class methods idempotent. This is a pattern similar to the one we have for Logger, Tracer, and Metrics. We have however decided to remove these decorators for the time being and ahead of the beta release.

Why is this needed?

The current implementation that we use for decorators is based on the TypeScript 4.x signature. With the release of TS 5.x the decorator signature has changed, and while we can't change the existing decorators overnight without causing breaking changes, we don't feel comfortable releasing an implementation that can be considered obsolete.

Likewise, we also don't feel comfortable releasing these specific decorators with the 5.x implementation while also having the other ones compatible with a different version, as we think this would cause confusion in those users who might use both.

For this reason we have decided to remove the implementation for now, and revisit the topic when we finally launch support for TS 5.x, to track this effort please refer to #1375

Which area does this relate to?

Idempotency

Solution

No response

Acknowledgment

Future readers

Please react with 👍 and your use case to help us understand customer demand.

@dreamorosi dreamorosi added internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) idempotency This item relates to the Idempotency Utility confirmed The scope is clear, ready for implementation labels Jun 26, 2023
@dreamorosi dreamorosi added this to the Idempotency - Beta release milestone Jun 26, 2023
@dreamorosi dreamorosi self-assigned this Jun 26, 2023
@dreamorosi dreamorosi linked a pull request Jun 26, 2023 that will close this issue
9 tasks
@github-project-automation github-project-automation bot moved this from Working on it to Coming soon in Powertools for AWS Lambda (TypeScript) Jun 28, 2023
@github-actions
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added pending-release This item has been merged and will be released soon and removed confirmed The scope is clear, ready for implementation labels Jun 28, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 29, 2023

This is now released under v1.11.0 version!

@github-actions github-actions bot added completed This item is complete and has been merged/shipped and removed pending-release This item has been merged and will be released soon labels Jun 29, 2023
@dreamorosi dreamorosi moved this from Coming soon to Shipped in Powertools for AWS Lambda (TypeScript) Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed This item is complete and has been merged/shipped idempotency This item relates to the Idempotency Utility internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Projects
Development

Successfully merging a pull request may close this issue.

1 participant