Skip to content

Docs: improve code highlight in dark mode #1693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 task done
am29d opened this issue Sep 19, 2023 · 2 comments · Fixed by #1695
Closed
1 task done

Docs: improve code highlight in dark mode #1693

am29d opened this issue Sep 19, 2023 · 2 comments · Fixed by #1695
Assignees
@am29d
Labels
completed This item is complete and has been merged/shipped documentation Improvements or additions to documentation

Comments

@am29d
Copy link
Contributor

am29d commented Sep 19, 2023

What were you searching in the docs?

The code highlight feature in the examples are unreadable in the dark mode.

image

Is this related to an existing documentation section?

all

How can we improve?

Change the highlight color to make it readable.

Got a suggestion in mind?

No response

Acknowledgment

  • I understand the final update might be different from my proposed suggestion, or refused.
@am29d am29d added documentation Improvements or additions to documentation triage This item has not been triaged by a maintainer, please wait labels Sep 19, 2023
@am29d am29d added confirmed The scope is clear, ready for implementation and removed triage This item has not been triaged by a maintainer, please wait labels Sep 19, 2023
@am29d am29d mentioned this issue Sep 19, 2023
Merged
9 tasks
@github-actions
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added pending-release This item has been merged and will be released soon and removed confirmed The scope is clear, ready for implementation labels Sep 19, 2023
@github-actions
Copy link
Contributor

This is now released under v1.13.1 version!

@github-actions github-actions bot added completed This item is complete and has been merged/shipped and removed pending-release This item has been merged and will be released soon labels Sep 21, 2023
@dreamorosi dreamorosi moved this from Coming soon to Shipped in Powertools for AWS Lambda (TypeScript) Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@am29d am29d

Labels
completed This item is complete and has been merged/shipped documentation Improvements or additions to documentation
Projects
Powertools for AWS Lambda (TypeScript)
Status: Shipped
Milestone
No milestone
1 participant
@am29d