Skip to content

Feature request: implement SQSFifoPartialProcessor class #1587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dreamorosi opened this issue Jul 7, 2023 · 2 comments · Fixed by #1606
Closed

Feature request: implement SQSFifoPartialProcessor class #1587

dreamorosi opened this issue Jul 7, 2023 · 2 comments · Fixed by #1606
Assignees
Labels
batch This item relates to the Batch Processing Utility completed This item is complete and has been merged/shipped feature-request This item refers to a feature request for an existing or new utility

Comments

@dreamorosi
Copy link
Contributor

Use Case

The Python version of Powertools for AWS features a class called SqsFifoPartialBatchProcessor class, which extends the BatchProcessor class. This class is needed because the use case of processing a batch of messages from an SQS configured as FIFO requires special handling. In the event of a failure, the whole batch must be marked as failed to maintain the order of the messages.

Solution/User Experience

Refer to the implementation found here, and specifically to the SqsFifoPartialBatchProcessor class.

Acceptance criteria

  • The class covers all the features found in the reference implementation
  • The class and its types are exported
  • Unit tests are implemented with 100% coverage
  • Classes and methods are documented via docstrings, following project's conventions as much as possible
@dreamorosi dreamorosi converted this from a draft issue Jul 7, 2023
@dreamorosi dreamorosi added feature-request This item refers to a feature request for an existing or new utility confirmed The scope is clear, ready for implementation batch This item relates to the Batch Processing Utility labels Jul 7, 2023
@erikayao93
Copy link
Contributor

I will be working on this soon.

@am29d am29d added this to the Batch processing - Beta release milestone Jul 12, 2023
@dreamorosi dreamorosi linked a pull request Jul 13, 2023 that will close this issue
9 tasks
@github-actions github-actions bot added pending-release This item has been merged and will be released soon and removed confirmed The scope is clear, ready for implementation labels Jul 13, 2023
@dreamorosi dreamorosi moved this from Backlog to Shipped in Powertools for AWS Lambda (TypeScript) Jul 13, 2023
@dreamorosi dreamorosi added completed This item is complete and has been merged/shipped and removed pending-release This item has been merged and will be released soon labels Jul 13, 2023
@github-project-automation github-project-automation bot moved this from Shipped to Coming soon in Powertools for AWS Lambda (TypeScript) Jul 13, 2023
@github-actions
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@dreamorosi dreamorosi moved this from Coming soon to Shipped in Powertools for AWS Lambda (TypeScript) Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
batch This item relates to the Batch Processing Utility completed This item is complete and has been merged/shipped feature-request This item refers to a feature request for an existing or new utility
Projects
Development

Successfully merging a pull request may close this issue.

3 participants