Skip to content

Maintenance: fix external links in readme files #1428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 of 2 tasks
dreamorosi opened this issue May 1, 2023 · 2 comments · Fixed by #1429
Closed
1 of 2 tasks

Maintenance: fix external links in readme files #1428

dreamorosi opened this issue May 1, 2023 · 2 comments · Fixed by #1429
Assignees
@dreamorosi
Labels
completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)

Comments

@dreamorosi
Copy link
Contributor

Summary

As a result of #1420 I mistakenly copied over some of the links that were intended for the docs to the README files, which break the rendering on GitHub.

Why is this needed?

GitHub markdown doesn’t render target="_blank" correctly, so it should be removed.

Which area does this relate to?

Other

Solution

No response

Acknowledgment

Future readers

Please react with 👍 and your use case to help us understand customer demand.
@dreamorosi dreamorosi self-assigned this May 1, 2023
This was referenced May 1, 2023
Merged
Merged
@dreamorosi dreamorosi changed the title fix external links in readme files Maintenance: fix external links in readme files May 2, 2023
@dreamorosi dreamorosi moved this from Backlog to Working on it in AWS Lambda Powertools for TypeScript May 2, 2023
@dreamorosi dreamorosi added internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) confirmed The scope is clear, ready for implementation labels May 2, 2023
@github-project-automation github-project-automation bot moved this from Working on it to Coming soon in AWS Lambda Powertools for TypeScript May 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2023

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added the pending-release This item has been merged and will be released soon label May 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2023 •
edited by dreamorosi
Loading

This is now released under v1.9.0 version!

@dreamorosi dreamorosi added completed This item is complete and has been merged/shipped and removed pending-release This item has been merged and will be released soon confirmed The scope is clear, ready for implementation labels Jun 9, 2023
@dreamorosi dreamorosi moved this from Coming soon to Shipped in AWS Lambda Powertools for TypeScript Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dreamorosi dreamorosi

Labels
completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(docs): fix external links in README files aws-powertools/powertools-lambda-typescript
1 participant
@dreamorosi