Skip to content

Maintenance: improve husky pre-commit hook #1359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 of 2 tasks
dreamorosi opened this issue Mar 9, 2023 · 1 comment · Fixed by #1360
Closed
1 of 2 tasks

Maintenance: improve husky pre-commit hook #1359

dreamorosi opened this issue Mar 9, 2023 · 1 comment · Fixed by #1360
Assignees
@dreamorosi
Labels
automation This item relates to automation completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)

Comments

@dreamorosi
Copy link
Contributor

Summary

As reported by @shdq on Discord, the current iteration of the pre-commit hook defined is not applying the eslint fixes in the correct order, and instead it's doing so in the files already committed.

Why is this needed?

The expected behavior should be to lint the staged files instead and fix them before they are committed.

Which area does this relate to?

Automation

Solution

No response

Acknowledgment

Future readers

Please react with 👍 and your use case to help us understand customer demand.
@dreamorosi dreamorosi added automation This item relates to automation internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) confirmed The scope is clear, ready for implementation labels Mar 9, 2023
@dreamorosi dreamorosi self-assigned this Mar 9, 2023
@dreamorosi dreamorosi mentioned this issue Mar 9, 2023
Merged
13 tasks
@dreamorosi dreamorosi linked a pull request Mar 9, 2023 that will close this issue
chore(ci): added lint-staged as pre-commit hook #1360
Merged
13 tasks
@github-project-automation github-project-automation bot moved this from Working on it to Coming soon in AWS Lambda Powertools for TypeScript Mar 10, 2023
@github-actions
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added the pending-release This item has been merged and will be released soon label Mar 10, 2023
@dreamorosi dreamorosi added completed This item is complete and has been merged/shipped and removed pending-release This item has been merged and will be released soon confirmed The scope is clear, ready for implementation labels Mar 10, 2023
@dreamorosi dreamorosi moved this from Coming soon to Shipped in AWS Lambda Powertools for TypeScript Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dreamorosi dreamorosi

Labels
automation This item relates to automation completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(ci): added lint-staged as pre-commit hook aws-powertools/powertools-lambda-typescript
1 participant
@dreamorosi