Skip to content

chore(metrics): fix tests when warnings are disabled #994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 4, 2022

Conversation

michaelbrewer
Copy link
Contributor

@michaelbrewer michaelbrewer commented Feb 3, 2022

Issue #, if available:

closes #993

Description of changes:

Changes:

  • set warnings.simplefilter(default)

Checklist

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Changes:
- run 'make format'
- set 'warnings.simplefilter(default)'

closes aws-powertools#993
@boring-cyborg boring-cyborg bot added the tests label Feb 3, 2022
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 3, 2022
@michaelbrewer michaelbrewer changed the title tests(metrics): fix tests when warnings are disabled test(metrics): fix tests when warnings are disabled Feb 3, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2022

Codecov Report

Merging #994 (f6bd1d5) into develop (168ec48) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #994   +/-   ##
========================================
  Coverage    99.96%   99.96%           
========================================
  Files          119      119           
  Lines         5347     5347           
  Branches       610      610           
========================================
  Hits          5345     5345           
  Partials         2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 168ec48...f6bd1d5. Read the comment docs.

@heitorlessa heitorlessa changed the title test(metrics): fix tests when warnings are disabled chore(metrics): fix tests when warnings are disabled Feb 4, 2022
@heitorlessa heitorlessa merged commit 6869155 into aws-powertools:develop Feb 4, 2022
@heitorlessa heitorlessa deleted the fix-993 branch February 4, 2022 16:44
@heitorlessa heitorlessa added the internal Maintenance changes label Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Maintenance changes size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests: metrics tests fail when PYTHONWARNINGS="ignore"
3 participants