-
Notifications
You must be signed in to change notification settings - Fork 421
feat(bedrock): add openapi_extensions
in BedrockAgentResolver
#6510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6510 +/- ##
===========================================
+ Coverage 96.14% 96.16% +0.02%
===========================================
Files 243 243
Lines 11844 11838 -6
Branches 885 885
===========================================
- Hits 11387 11384 -3
+ Misses 359 356 -3
Partials 98 98 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool feature! Approved 🚀
|
Issue number: #6500
Summary
The BedrockAgentResolver class currently doesn't expose the
openapi_extensions
parameter in its route decorators, which is necessary for enabling Bedrock Agent user confirmations. To enable user confirmations in Bedrock Agents, we need to set"x-requireConfirmation":"ENABLED"
in the API schema file.Changes:
openapi_extensions
parameter to route decorators in BedrockAgentResolverUser experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.