Skip to content

feat(bedrock): add openapi_extensions in BedrockAgentResolver #6510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 17, 2025

Conversation

leandrodamascena
Copy link
Contributor

Issue number: #6500

Summary

The BedrockAgentResolver class currently doesn't expose the openapi_extensions parameter in its route decorators, which is necessary for enabling Bedrock Agent user confirmations. To enable user confirmations in Bedrock Agents, we need to set "x-requireConfirmation":"ENABLED" in the API schema file.

Changes:

  • Added openapi_extensions parameter to route decorators in BedrockAgentResolver
  • Ensured parameter is properly passed to parent class implementation
  • Added documentation
  • Added a test case demonstrating usage with Bedrock Agent user confirmations

User experience

@app.get("/confirm-action", openapi_extensions={"x-requireConfirmation": "ENABLED"})
def confirm_action():
    return {"message": "Action confirmed"}

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@leandrodamascena leandrodamascena requested a review from a team as a code owner April 17, 2025 15:50
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 17, 2025
@boring-cyborg boring-cyborg bot added documentation Improvements or additions to documentation event_handlers tests labels Apr 17, 2025
@github-actions github-actions bot added feature New feature or functionality and removed documentation Improvements or additions to documentation labels Apr 17, 2025
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Apr 17, 2025
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Apr 17, 2025
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Apr 17, 2025
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Apr 17, 2025
Copy link

codecov bot commented Apr 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.16%. Comparing base (2c2d8e8) to head (c430ddd).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6510      +/-   ##
===========================================
+ Coverage    96.14%   96.16%   +0.02%     
===========================================
  Files          243      243              
  Lines        11844    11838       -6     
  Branches       885      885              
===========================================
- Hits         11387    11384       -3     
+ Misses         359      356       -3     
  Partials        98       98              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@anafalcao anafalcao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool feature! Approved 🚀

@leandrodamascena leandrodamascena linked an issue Apr 17, 2025 that may be closed by this pull request
2 tasks
@leandrodamascena leandrodamascena self-assigned this Apr 17, 2025
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Apr 17, 2025
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Apr 17, 2025
@leandrodamascena leandrodamascena merged commit e9cb5e5 into develop Apr 17, 2025
14 checks passed
@leandrodamascena leandrodamascena deleted the feat/openapi-extension branch April 17, 2025 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
event_handlers feature New feature or functionality size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Enable Bedrock Agents user confirmation
2 participants