Skip to content

docs(bedrock_agents): remove Pydantic v1 recommendation #6468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

konokenj
Copy link
Contributor

@konokenj konokenj commented Apr 15, 2025

Issue number: #6476

Summary

Remove the statement recommending Pydantic v1 from the Bedrock Agents documentation. Lambda PowerTools is now able to generate OpenAPI schemas for Bedrock Agents using Pydantic v2 by #5156.

Changes

  • docs/core/event_handler/bedrock_agents.md

User experience

Users will be able to avoid wasting time by installing Pydantic v1 according to the documentation.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@konokenj konokenj requested a review from a team as a code owner April 15, 2025 13:45
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Apr 15, 2025
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 15, 2025
Copy link

boring-cyborg bot commented Apr 15, 2025

Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need.
In the meantime, check out the #python channel on our Powertools for AWS Lambda Discord: Invite link

@konokenj konokenj changed the title docs: Remove recommend for Pydantic v1 which not supported in v3 docs(bedrock_agents): Remove recommend for Pydantic v1 which not supported in v3 Apr 15, 2025
@leandrodamascena
Copy link
Contributor

Hey @konokenj! Thanks a lot for fixing the documentation!

Hey @anafalcao, can you please open an issue and link it here? Also, please review the PR.

@leandrodamascena leandrodamascena requested review from anafalcao and removed request for leandrodamascena April 15, 2025 15:52
@anafalcao anafalcao linked an issue Apr 15, 2025 that may be closed by this pull request
1 task
@anafalcao
Copy link
Contributor

Hey @konokenj and @leandrodamascena ! Thanks for the contribution here.
Issue created and linked, I will now review this PR.

@leandrodamascena leandrodamascena changed the title docs(bedrock_agents): Remove recommend for Pydantic v1 which not supported in v3 docs(bedrock_agents): remove Pydantic v1 recommendation Apr 15, 2025
Copy link
Contributor

@anafalcao anafalcao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! Thanks again

@leandrodamascena leandrodamascena merged commit b5f6bec into aws-powertools:develop Apr 15, 2025
2 of 3 checks passed
Copy link

boring-cyborg bot commented Apr 15, 2025

Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience!

@konokenj konokenj deleted the feature/doc-remove-pydantic-v1 branch April 16, 2025 02:52
leandrodamascena added a commit that referenced this pull request Apr 24, 2025
* docs: Remove recommend for Pydantic v1 which not supported in v3

* remove pydantic v1 from rest api doc

---------

Co-authored-by: Ana Falcão <[email protected]>
Co-authored-by: Ana Falcao <[email protected]>
Co-authored-by: Leandro Damascena <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: update Bedrock Agents for Pydantic v2 support
3 participants