-
Notifications
You must be signed in to change notification settings - Fork 421
feat(logger): add support for exception notes #6465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey @anafalcao! Can you please review this? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6465 +/- ##
========================================
Coverage 96.32% 96.33%
========================================
Files 243 243
Lines 11824 11826 +2
Branches 881 881
========================================
+ Hits 11390 11392 +2
Misses 338 338
Partials 96 96 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR! APPROVED 🚀
* Adding support for exception notes * Adding support for exception notes * Python... --------- Co-authored-by: Ana Falcão <[email protected]>
Issue number: #6441
Summary
This PR adds support for exception notes in the logger. When using
logger.exception
, any notes attached to exceptions will now be propagated and included in the log line under a newexception_notes
key.Exception notes provide additional context for errors, making debugging easier and logs more informative.
User experience
and the output:
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.