-
Notifications
You must be signed in to change notification settings - Fork 421
feat(event_handler): add extras HTTP Error Code Exceptions #6454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6454 +/- ##
========================================
Coverage 96.32% 96.32%
========================================
Files 243 243
Lines 11812 11824 +12
Branches 881 881
========================================
+ Hits 11378 11390 +12
Misses 338 338
Partials 96 96 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hello @kazu728! Thank you for the PR, I'll review it and get back to you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sending this PR @kazu728! And thanks for fixing small things @anafalcao!
APPROVED!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved!! Thank you again for the work here
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
* feat(event_handler): add error status * update doc with new errors * fix typo * change class description --------- Co-authored-by: Ana Falcão <[email protected]> Co-authored-by: Ana Falcao <[email protected]> Co-authored-by: Leandro Damascena <[email protected]>
Issue number: #6379
Summary
Currently, the Event Handler REST API provides pre-defined errors for HTTP 400, 401, 404, 500. This PR adds 4 more, based on the API calls CommomErrors, meaning adding 403, 413, 408 e 503.
Changes
The user can easily throw ForbiddenError (403), RequestTimeoutError (408), RequestEntityTooLargeError (413) and ServiceUnavailableError (503).
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.