Skip to content

docs(bedrock): fix BedrockServiceRole in template.yaml #6436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2025

Conversation

GuidoNebiolo
Copy link
Contributor

@GuidoNebiolo GuidoNebiolo commented Apr 10, 2025

Issue number: #6438

Summary

Changes

Fixing indentation of AssumeRolePolicyDocument content in BedrockServiceRole in template.yaml that prevent the SAM template to be deployed correctly.

User experience

N/A

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

Fixing indentation of AssumeRolePolicyDocument content in BedrockServiceRole that prevent the template to be deployed correctly.

Signed-off-by: Guido Nebiolo <[email protected]>
@GuidoNebiolo GuidoNebiolo requested a review from a team as a code owner April 10, 2025 03:16
@GuidoNebiolo GuidoNebiolo requested a review from anafalcao April 10, 2025 03:16
Copy link

boring-cyborg bot commented Apr 10, 2025

Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need.
In the meantime, check out the #python channel on our Powertools for AWS Lambda Discord: Invite link

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 10, 2025
@leandrodamascena leandrodamascena linked an issue Apr 10, 2025 that may be closed by this pull request
1 task
@leandrodamascena leandrodamascena changed the title fix BedrockServiceRole in template.yaml docs(bedrock): fix BedrockServiceRole in template.yaml Apr 10, 2025
Copy link
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @GuidoNebiolo thanks a lot for fixing this!!

APPROVED!

Copy link

codecov bot commented Apr 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.33%. Comparing base (aebebb8) to head (e4dd480).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6436   +/-   ##
========================================
  Coverage    96.33%   96.33%           
========================================
  Files          243      243           
  Lines        11763    11763           
  Branches       871      871           
========================================
  Hits         11332    11332           
  Misses         337      337           
  Partials        94       94           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leandrodamascena leandrodamascena merged commit 54648da into aws-powertools:develop Apr 10, 2025
12 checks passed
Copy link

boring-cyborg bot commented Apr 10, 2025

Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience!

leandrodamascena added a commit that referenced this pull request Apr 24, 2025
Fix BedrockServiceRole in template.yaml

Fixing indentation of AssumeRolePolicyDocument content in BedrockServiceRole that prevent the template to be deployed correctly.

Signed-off-by: Guido Nebiolo <[email protected]>
Co-authored-by: Leandro Damascena <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: fix BedrockServiceRole in template.yaml
2 participants