-
Notifications
You must be signed in to change notification settings - Fork 421
docs(bedrock): fix BedrockServiceRole in template.yaml #6436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(bedrock): fix BedrockServiceRole in template.yaml #6436
Conversation
Fixing indentation of AssumeRolePolicyDocument content in BedrockServiceRole that prevent the template to be deployed correctly. Signed-off-by: Guido Nebiolo <[email protected]>
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @GuidoNebiolo thanks a lot for fixing this!!
APPROVED!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6436 +/- ##
========================================
Coverage 96.33% 96.33%
========================================
Files 243 243
Lines 11763 11763
Branches 871 871
========================================
Hits 11332 11332
Misses 337 337
Partials 94 94 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
Fix BedrockServiceRole in template.yaml Fixing indentation of AssumeRolePolicyDocument content in BedrockServiceRole that prevent the template to be deployed correctly. Signed-off-by: Guido Nebiolo <[email protected]> Co-authored-by: Leandro Damascena <[email protected]>
Issue number: #6438
Summary
Changes
Fixing indentation of
AssumeRolePolicyDocument
content inBedrockServiceRole
in template.yaml that prevent the SAM template to be deployed correctly.User experience
N/A
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.