-
Notifications
You must be signed in to change notification settings - Fork 421
feat(metrics): allow change ColdStart function_name dimension #6315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6315 +/- ##
========================================
Coverage 96.32% 96.32%
========================================
Files 242 242
Lines 11676 11689 +13
Branches 865 867 +2
========================================
+ Hits 11247 11260 +13
Misses 336 336
Partials 93 93 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, nice
Issue number: #6309
Summary
This PR adds the ability to configure a custom function name for metrics, which is especially useful when capturing cold start metrics. It provides more control over metrics naming, solving the issue where CDK deployments can result in random characters added to function names.
Changes
We adding in this PR:
function_name
parameter to theMetrics
constructorPOWERTOOLS_METRICS_FUNCTION_NAME
environment variableUser experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.