refactor(data_classes): simplify nested data classes

[ericbn]

Issue number: #6292

Summary

Changes

Make each nested data class only know its own properties instead of having to reference from the root of the data. This hopefully simplifies the code and avoids DRY. Also simplify test cases.

User experience

No user experience change.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

• Meet tenets criteria
• I have performed a self-review of this change
• Changes have been tested
• Changes are documented
• PR title follows conventional commit semantics

Is this a breaking change?

RFC issue number:

Checklist:

• Migration process documented
• Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

[github-actions]

No related issues found. Please ensure there is an open issue related to this change to avoid significant delays or closure.

[leandrodamascena]

Hi @ericbn! Thanks for submitting this PR and streamlining the event source code! I see some tests are failing, could you please take a look?

In the meantime, I'll open an issue to link to this PR and keep things in order.

[leandrodamascena]

Need to fix tests.

[ericbn]

I've pushed a new commit here but the PR is still stuck by GitHub in "processing updates"...

[leandrodamascena]

I've pushed a new commit here but the PR is still stuck by GitHub in "processing updates"...

Please push another small commit and lets see if GH works.

[ericbn]

Done. Seems to be unstuck now!

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.31%. Comparing base (448ff56) to head (49216cd).
Report is 2 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #6289      +/-   ##
===========================================
- Coverage    96.32%   96.31%   -0.01%     
===========================================
  Files          241      241              
  Lines        11633    11625       -8     
  Branches       864      862       -2     
===========================================
- Hits         11205    11197       -8     
  Misses         336      336              
  Partials        92       92              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[leandrodamascena]

APPROVED! Thanks @ericbn!