refactor(data_classes): remove duplicated code

[ericbn]

Issue number: #6293

Summary

Changes

Remove overriding methods that have the same code as the overriden ones.

User experience

No user experience change.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

• Meet tenets criteria
• I have performed a self-review of this change
• Changes have been tested
• Changes are documented
• PR title follows conventional commit semantics

Is this a breaking change?

RFC issue number:

Checklist:

• Migration process documented
• Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

[github-actions]

No related issues found. Please ensure there is an open issue related to this change to avoid significant delays or closure.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.33%. Comparing base (cdcf850) to head (a1a30f8).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #6288   +/-   ##
========================================
  Coverage    96.32%   96.33%           
========================================
  Files          242      242           
  Lines        11716    11699   -17     
  Branches       865      864    -1     
========================================
- Hits         11286    11270   -16     
+ Misses         337      336    -1     
  Partials        93       93           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[ericbn]

Just found a few more cases of duplicated code using pylint and manually checking its report:

$ pip install pylint
$ pylint --disable=all --enable=R0801 --min-similarity-lines=1

Added a commit to the PR.

[leandrodamascena]

Hi @ericbn! Do you need my review now or are you still doing some work?

[ericbn]

If you agree we can merge this. I still want to see if we can further simplify duplicated code by creating common base classes, but that's a refactoring of a different nature, so could go in a separate PR. I'm planning to check that between today and tomorrow.

[leandrodamascena]

If you agree we can merge this. I still want to see if we can further simplify duplicated code by creating common base classes, but that's a refactoring of a different nature, so could go in a separate PR. I'm planning to check that between today and tomorrow.

I'd prefer if you just remove redundant methods in this PR and then we can decide what to do with other things in a separate PR.

[leandrodamascena]

Hey @ericbn! just two small comments before we merge it.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[leandrodamascena]

APROVED! Obrigado @ericbn

[ericbn]

Created PR #6297 with the other duplicate code change discussed here.