Skip to content

refactor(tests): add LambdaContext type in tests #6214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

basvandriel
Copy link
Contributor

@basvandriel basvandriel commented Mar 4, 2025

Issue number: #6215

Summary

This pull request adds types to the LambdaContext fixtures in the examples. This makes the examples more robust and easier to read.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@boring-cyborg boring-cyborg bot added the tests label Mar 4, 2025
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 4, 2025
@basvandriel basvandriel changed the title Type LambdaContext types in tests docs:typed-examples Type LambdaContext types in tests Mar 4, 2025
@basvandriel basvandriel marked this pull request as ready for review March 4, 2025 15:36
@basvandriel basvandriel requested a review from a team as a code owner March 4, 2025 15:36
@leandrodamascena leandrodamascena changed the title docs:typed-examples Type LambdaContext types in tests refactor(tests): add LambdaContext type in tests Mar 4, 2025
@github-actions github-actions bot added documentation Improvements or additions to documentation enhancement labels Mar 4, 2025
@leandrodamascena leandrodamascena linked an issue Mar 5, 2025 that may be closed by this pull request
1 task
@basvandriel
Copy link
Contributor Author

Hi @leandrodamascena, can we retry the code quality step? I can't seem to reproduce the failure locally.

@leandrodamascena
Copy link
Contributor

Hi @leandrodamascena, can we retry the code quality step? I can't seem to reproduce the failure locally.

Hi @basvandriel! I'm running it again! I don't know what's going on, but when our CI runs on specific runners on GitHub, it fails some tests with multithreads. I'll refactor it to create better isolation.

For now, let's see if I can run the pipeline here, otherwise I'll pull this PR and run it locally.

Copy link
Contributor

@anafalcao anafalcao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved!!

Copy link
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @basvandriel! Thanks for another super great PR! I just pushed a commit with some documentation highlight changes, but nothing major.

CI is still failing, but because another test! I'll fix it in a separate PR, but I could run this PR locally and everything is ok.

I'm approving but will merge tomorrow, after our release!

@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Mar 6, 2025
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Mar 7, 2025
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Mar 7, 2025
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Mar 7, 2025
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Mar 7, 2025
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.30%. Comparing base (609faeb) to head (6a6aa7e).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6214   +/-   ##
========================================
  Coverage    96.30%   96.30%           
========================================
  Files          240      240           
  Lines        11572    11572           
  Branches       858      858           
========================================
  Hits         11144    11144           
  Misses         336      336           
  Partials        92       92           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Mar 7, 2025
Copy link

sonarqubecloud bot commented Mar 7, 2025

@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Mar 7, 2025
@leandrodamascena leandrodamascena merged commit 83222dd into aws-powertools:develop Mar 7, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: improve examples with typed examples of LambdaContext dataclasses
3 participants