-
Notifications
You must be signed in to change notification settings - Fork 421
refactor(tests): add LambdaContext type in tests #6214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(tests): add LambdaContext type in tests #6214
Conversation
LambdaContext
types in testsLambdaContext
types in tests
LambdaContext
types in tests
Hi @leandrodamascena, can we retry the code quality step? I can't seem to reproduce the failure locally. |
Hi @basvandriel! I'm running it again! I don't know what's going on, but when our CI runs on specific runners on GitHub, it fails some tests with multithreads. I'll refactor it to create better isolation. For now, let's see if I can run the pipeline here, otherwise I'll pull this PR and run it locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @basvandriel! Thanks for another super great PR! I just pushed a commit with some documentation highlight changes, but nothing major.
CI is still failing, but because another test! I'll fix it in a separate PR, but I could run this PR locally and everything is ok.
I'm approving but will merge tomorrow, after our release!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6214 +/- ##
========================================
Coverage 96.30% 96.30%
========================================
Files 240 240
Lines 11572 11572
Branches 858 858
========================================
Hits 11144 11144
Misses 336 336
Partials 92 92 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
83222dd
into
aws-powertools:develop
Issue number: #6215
Summary
This pull request adds types to the
LambdaContext
fixtures in the examples. This makes the examples more robust and easier to read.Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.