-
Notifications
You must be signed in to change notification settings - Fork 421
feat(event_handler): add custom method for OpenAPI configuration #6204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6204 +/- ##
===========================================
+ Coverage 96.30% 96.32% +0.01%
===========================================
Files 240 241 +1
Lines 11596 11633 +37
Branches 862 864 +2
===========================================
+ Hits 11168 11205 +37
Misses 336 336
Partials 92 92 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f943f45
to
863d6f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left only one comment about a default value, other than that it looks good.
Great improvement for customers!
|
Issue number: #6122
Summary
Changes
This PR introduces a new method
configure_openapi()
to simplify OpenAPI configuration while maintaining backwards compatibility.Currently, OpenAPI configuration must be specified in both
enable_swagger()
andget_openapi_json_schema()
methods, leading to:User experience
Introduce a new
configure_openapi()
method while preserving existing functionality:Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.