-
Notifications
You must be signed in to change notification settings - Fork 421
refactor(tracer): fix capture_lambda_handler return type annotation #6197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(tracer): fix capture_lambda_handler return type annotation #6197
Conversation
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6197 +/- ##
========================================
Coverage 96.25% 96.25%
========================================
Files 236 236
Lines 11407 11407
Branches 830 830
========================================
Hits 10980 10980
Misses 337 337
Partials 90 90 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for sending this PR @tiagohconte! APPROVED!
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
Issue number: #6188
Summary
Changes
Added return type annotation for the
capture_lambda_handler
decorator.User experience
A type error message
Argument missing for parameter "context"
was shown when usingcapture_lambda_handler
with parameters.Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.