fix(logger): child logger must respect log level #5950
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #5949
Summary
Changes
This PR addresses an issue where child loggers are unable to set different log levels from their parent loggers.
Currently, when creating a child logger using Powertools, the log level set for the child logger is not respected. This limits the ability to have different parts of an application log at different levels of verbosity.
Changes
Logger
class initialization to check if it's a child loggerExample
Backwards Compatibility
This change is backwards compatible. Existing code using Powertools loggers will continue to work as before, with the added benefit of respecting log levels for child loggers when explicitly set.
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.