Skip to content

chore(ci): fix dependency resolution #5858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 13, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/quality_check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ jobs:
with:
python-version: ${{ matrix.python-version }}
- name: Install dependencies
run: make dev
run: make dev-quality-code
- name: Formatting and Linting
run: make lint
- name: Static type checking
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/run-e2e-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ jobs:
npm ci
npx cdk --version
- name: Install dependencies
run: make dev
run: dev-quality-code
- name: Configure AWS credentials
uses: aws-actions/configure-aws-credentials@5fd3084fc36e372ff1fff382a39b10d03659f355 # v2.2.0
with:
Expand Down
9 changes: 7 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,12 @@ target:

dev:
pip install --upgrade pip pre-commit poetry
# @$(MAKE) dev-version-plugin
@$(MAKE) dev-version-plugin
poetry install --extras "all redis datamasking"
pre-commit install

dev-quality-code:
pip install --upgrade pip pre-commit poetry
poetry install --extras "all redis datamasking"
pre-commit install

Expand Down Expand Up @@ -115,4 +120,4 @@ mypy:


dev-version-plugin:
poetry self add git+https://github.com/monim67/poetry-bumpversion@315fe3324a699fa12ec20e202eb7375d4327d1c4
poetry self add git+https://github.com/monim67/poetry-bumpversion@348de6f247222e2953d649932426e63492e0a6bf
1 change: 0 additions & 1 deletion docs/we_made_this.md
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,6 @@ Learn to implement data masking in AWS Lambda with Powertools, protecting sensit
[Simplified Data Masking in AWS Lambda with Powertools](https://www.internetkatta.com/simplified-data-masking-in-aws-lambda-with-powertool){target="_blank" rel="nofollow"}


## Videos

#### Building a resilient input handling with Parser
Expand Down
Loading
Loading