Skip to content

fix(api-gateway): route regression for non-word and unsafe URI chars #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

heitorlessa
Copy link
Contributor

Issue #, if available: #550

Description of changes:

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 23, 2021
@pull-request-size pull-request-size bot removed the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 23, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2021

Codecov Report

Merging #556 (db20c9b) into develop (a768b68) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #556   +/-   ##
========================================
  Coverage    99.86%   99.86%           
========================================
  Files          113      113           
  Lines         4483     4483           
  Branches       243      243           
========================================
  Hits          4477     4477           
  Misses           3        3           
  Partials         3        3           
Impacted Files Coverage Δ
aws_lambda_powertools/event_handler/api_gateway.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a768b68...db20c9b. Read the comment docs.

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 23, 2021
@heitorlessa heitorlessa marked this pull request as ready for review July 23, 2021 19:22
@heitorlessa heitorlessa added the bug Something isn't working label Jul 23, 2021
@heitorlessa
Copy link
Contributor Author

@michaelbrewer mind having a second look before I release the patch version?

Thank you!

@heitorlessa
Copy link
Contributor Author

alright, it's nearly 10pm here, I'm going ahead and checking with the OP

@heitorlessa heitorlessa merged commit 7ecae1e into aws-powertools:develop Jul 23, 2021
@heitorlessa heitorlessa deleted the fix/apigw-route-regression branch July 23, 2021 19:25
@heitorlessa heitorlessa changed the title fix(apigw): route regression for non-word chars 1st take fix(apigw): route regression for non-word chars Jul 23, 2021
@heitorlessa heitorlessa changed the title fix(apigw): route regression for non-word chars fix(apigw): route regression for non-word and unsafe URI chars Jul 23, 2021
@heitorlessa heitorlessa changed the title fix(apigw): route regression for non-word and unsafe URI chars fix(api-gateway): route regression for non-word and unsafe URI chars Jul 23, 2021
@michaelbrewer
Copy link
Contributor

@heitorlessa works for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants