Skip to content

feat(layers): introduce new CDK Python constructor for Powertools Lambda Layer #5320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 8, 2024

Conversation

leandrodamascena
Copy link
Contributor

@leandrodamascena leandrodamascena commented Oct 6, 2024

Issue number: #5278

Summary

Changes

This PR introduces a new CDK Python constructor for creating Lambda Layers, replacing the previously used powertools-lambda-layer-cdk project. This change aims to simplify our project structure, improve control over dependencies, and enhance our release process efficiency.

We've decided to move away from the powertools-lambda-layer-cdk project due to some issues:

  1. Projen usage: The powertools-lambda-layer-cdk uses projen, which has caused issues in the past, particularly with its obscure management of transitive dependencies.
  2. Lack of documentation: The powertools-lambda-layer-cdk project is poorly documented, leading to uncertainties in our automation processes.
  3. Unnecessary complexity: Using an external CDK constructor for a layer we have full control over adds unnecessary complexity to our project.
  4. Release process slowdown: The external constructor has been slowing down our release process by approximately 10 minutes.

Changes

  • Removed dependency on powertools-lambda-layer-cdk
  • Introduced a new custom CDK Python constructor for creating Lambda Layers
  • Adjusted CI/CD pipelines to utilize the new constructor
  • Added a new quality check step for this constructor

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@leandrodamascena leandrodamascena requested a review from a team October 6, 2024 20:19
@boring-cyborg boring-cyborg bot added dependencies Pull requests that update a dependency file github-actions Pull requests that update Github_actions code labels Oct 6, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 6, 2024
@leandrodamascena leandrodamascena added the on-hold This item is on-hold and will be revisited in the future label Oct 6, 2024
@github-actions github-actions bot added the feature New feature or functionality label Oct 6, 2024
Copy link

sonarqubecloud bot commented Oct 6, 2024

@leandrodamascena leandrodamascena added do-not-merge and removed feature New feature or functionality labels Oct 6, 2024
@github-actions github-actions bot added the feature New feature or functionality label Oct 6, 2024
@dreamorosi dreamorosi marked this pull request as draft October 7, 2024 10:38
@leandrodamascena leandrodamascena marked this pull request as ready for review November 7, 2024 17:34
@leandrodamascena
Copy link
Contributor Author

working on the last changes before asking for review.

Copy link

sonarqubecloud bot commented Nov 7, 2024

@leandrodamascena
Copy link
Contributor Author

@dreamorosi dreamorosi removed dependencies Pull requests that update a dependency file do-not-merge on-hold This item is on-hold and will be revisited in the future labels Nov 8, 2024
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this.

In the coming weeks I will write a small internal RFC to decide whether we should continue supporting the standalone CDK construct repository, and move this logic there or deprecate it.

As you pointed out, that repository is lacking a clear purpose and some of the decisions that were made created some tech debt that was not addressed promptly.

If we are to continue supporting that CDK construct we should solve these issues and define a clear support model.

@leandrodamascena leandrodamascena merged commit 1d58023 into develop Nov 8, 2024
9 checks passed
@leandrodamascena leandrodamascena deleted the layer/new-constructor branch November 8, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or functionality github-actions Pull requests that update Github_actions code size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Remove powertools-lambda-layer-cdk project when building Lambda layers
2 participants