fix(v3): revert unnecessary changes that impacts v3 #5087
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
documentation
pull-request-size
bot
added
the
size/XL
leandrodamascena
changed the title
github-actions
bot
added
bug
boring-cyborg
bot
added
the
documentation
github-actions
bot
removed
the
documentation
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #5029
Summary
Changes
The V3 branch does not yet have nox installed to perform dependency testing and some of our changes have created some unexpected cross-dependency breaking changes.
Here is the list of breaking changes detected so far:
1 - We can't import BaseModel outside of TYPE_CHECKING because it will force to bring Pydantic at Runtime level even not using data_validation - v3/aws_lambda_powertools/event_handler/openapi/types.py#L7
2 - We can't import ConfigDict because we will force to bring Pydantic event not using data_validation - v3/aws_lambda_powertools/event_handler/openapi/constants.py#L1
3 - We need to restore get_header.. and get_querystring.. functions removed by this PR - #4606 (files)
4 - Removed unnecessary examples.
5 - Deprecated get_header method.
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.