Skip to content

docs(logger): fix typo for the INFO log_level example #5039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ashemedai
Copy link
Contributor

@ashemedai ashemedai commented Aug 21, 2024

Issue number: #5037

Summary

Fix typo for the INFO log_level example

Changes

This fixes a typo in the log_level example that could mislead people in using this property in their code.

User experience

Before: wrong information in example
After: correct information in example

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@ashemedai ashemedai requested a review from a team August 21, 2024 09:26
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Aug 21, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 21, 2024
Copy link

boring-cyborg bot commented Aug 21, 2024

Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need.
In the meantime, check out the #python channel on our Powertools for AWS Lambda Discord: Invite link

Copy link

@leandrodamascena leandrodamascena changed the title docs(logger): Fix typo for the INFO log_level example docs(logger): fix typo for the INFO log_level example Aug 21, 2024
@leandrodamascena leandrodamascena linked an issue Aug 21, 2024 that may be closed by this pull request
1 task
Copy link
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVED! Thanks for opening this PR so fast @ashemedai!

@leandrodamascena leandrodamascena merged commit c0ced01 into aws-powertools:develop Aug 21, 2024
14 checks passed
Copy link

boring-cyborg bot commented Aug 21, 2024

Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience!

@ashemedai ashemedai deleted the fix_log_level_typo branch August 21, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Minor typo for log_level example
2 participants