Skip to content

refactor(tracing): add from __future__ import annotations #4943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 15, 2024

Conversation

ericbn
Copy link
Contributor

@ericbn ericbn commented Aug 13, 2024

Issue number: #4954

Summary

Changes

Add from __future__ import annotations to tracing package

User experience

Discussed in #4607

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

and update code according to ruff rules TCH, UP006, UP007, UP037 and
FA100.
@ericbn ericbn requested a review from a team August 13, 2024 01:21
@boring-cyborg boring-cyborg bot added the tracer Tracer utility label Aug 13, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 13, 2024
@leandrodamascena leandrodamascena linked an issue Aug 13, 2024 that may be closed by this pull request
2 tasks
@boring-cyborg boring-cyborg bot added the tests label Aug 15, 2024
Copy link
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVED!

Copy link

@leandrodamascena leandrodamascena merged commit b0006dd into aws-powertools:v3 Aug 15, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tests tracer Tracer utility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tech debt: add from __future__ import annotations in the Tracing feature
2 participants