-
Notifications
You must be signed in to change notification settings - Fork 420
refactor(jmespath_utils): deprecate extract_data_from_envelope in favor of query #4907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…espath_utils and replace with query issue: aws-powertools#4218
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @n-k1! Thank you so much for taking the time to make this PR and having attention to details. I made a small change to it by adding a decorator to say that the method was deprecated and I changed the exception type.
This will be included in our major version v3!!
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
Issue number: #4218
Summary
Changes
query
method injmespath_utils/__init__.py
with the same implementation asextract_data_from_envelope
extract_data_from_envelope
and updated docstringUser experience
extract_data_from_envelope
will continue to work with a deprecation warning and will be removed in the next major version.query
will replaceextract_data_from_envelope
.Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
This is not a breaking change.
extract_data_from_envelope
will continue to work with a deprecation warning and will only be removed in the next major version.RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.