chore(ci): add the Idempotency feature to nox tests #4585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/L
|
|
||
| @nox.session() | ||
| @nox.parametrize("pydantic", ["1.10", "2.0"]) | ||
| def test_with_boto3_and_pydantic_required_package(session: nox.Session, pydantic: str): |
There was a problem hiding this comment.
I need to install pydantic + boto3 because we export the DynamoDBPersistenceLayer at top level and it requires boto3.
There was a problem hiding this comment.
I think you meant you only needed boto3 when using DynamoDBPersistenceLayer, whereas for this test you also need pydantic because it'll use serializers and models.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4585 +/- ##
===========================================
+ Coverage 96.38% 96.43% +0.05%
===========================================
Files 214 219 +5
Lines 10030 10628 +598
Branches 1846 1976 +130
===========================================
+ Hits 9667 10249 +582
- Misses 259 267 +8
- Partials 104 112 +8 ☔ View full report in Codecov by Sentry. |
heitorlessa
approved these changes
Jun 20, 2024
leandrodamascena
merged commit 9486472
into
aws-powertools:develop
23 of 24 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #4560
Summary
Changes
Adding the Idempotency feature to nox tests
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.