Skip to content

chore(governance): fix errors when creating Gitpod environment #4532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

leandrodamascena
Copy link
Contributor

Issue number: #4530

Summary

Changes

This PR resolves the issue of Gitpod environment configuration by removing the poetry-bumpversion plugin from the initial setup. This plugin is not necessary in a development environment, as the only way we perform library versioning is through our CI/CD pipeline.

Additionally, I have taken the opportunity to update the environment to use Python 3.11.

User experience

image

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@leandrodamascena leandrodamascena requested a review from a team June 15, 2024 23:48
@boring-cyborg boring-cyborg bot added the internal Maintenance changes label Jun 15, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 15, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@leandrodamascena leandrodamascena linked an issue Jun 15, 2024 that may be closed by this pull request
2 tasks
@leandrodamascena leandrodamascena changed the title chore(governance): fix problems with Gitpod configuration chore(governance): fix errors when creating Gitpod environment Jun 15, 2024
Copy link
Contributor

@heitorlessa heitorlessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we perhaps use 3.12 (latest) instead of 3.11 given the opportunity?

@leandrodamascena
Copy link
Contributor Author

leandrodamascena commented Jun 17, 2024

should we perhaps use 3.12 (latest) instead of 3.11 given the opportunity?

Yeah, I tried that but for some reason the gitpod workspace for python3.12 is breaking some dependencies. I need to investigate more, but I think it's ok to use 3.11 for now. WDYT?

@heitorlessa
Copy link
Contributor

heitorlessa commented Jun 17, 2024 via email

@leandrodamascena leandrodamascena merged commit 55f51b5 into aws-powertools:develop Jun 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Maintenance changes size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: Fix error when creating a developer environment in Gitpod
2 participants