Skip to content

chore(libraries): add jmespath as a required dependency #4422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

leandrodamascena
Copy link
Contributor

Issue number: #4340

Summary

Changes

This pull requests addresses an issue where the Logger utility/and others fails to work due to missing jmespath dependency.

The issue occurs in environments that are not AWS Lambda/emulations, as these environments already include the jmespath library by default. However, when running the Logger utility in other environments, such as local development or non-Lambda deployments, the ModuleNotFoundError: No module named 'jmespath' error is raised due to the missing dependency.

User experience

Customers now do not need to install jmespath after installing the Powertools package.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@leandrodamascena leandrodamascena requested a review from a team May 28, 2024 22:36
@boring-cyborg boring-cyborg bot added the dependencies Pull requests that update a dependency file label May 28, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 28, 2024
@leandrodamascena leandrodamascena linked an issue May 28, 2024 that may be closed by this pull request
@leandrodamascena leandrodamascena changed the title chore(libraries): add jmespath as required library chore(libraries): add jmespath as a required dependency May 28, 2024
dreamorosi
dreamorosi previously approved these changes May 29, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.32%. Comparing base (e14e768) to head (f31416d).
Report is 505 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4422      +/-   ##
===========================================
- Coverage    96.38%   96.32%   -0.06%     
===========================================
  Files          214      218       +4     
  Lines        10030    10478     +448     
  Branches      1846     1941      +95     
===========================================
+ Hits          9667    10093     +426     
- Misses         259      271      +12     
- Partials       104      114      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leandrodamascena leandrodamascena merged commit f3a45b5 into aws-powertools:develop May 29, 2024
15 of 16 checks passed
@leandrodamascena leandrodamascena deleted the jmespath-required-extension branch May 29, 2024 10:08
@github-actions github-actions bot added the internal Maintenance changes label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file internal Maintenance changes size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: jmespath is an undeclared dependency of Logger utility
3 participants