Skip to content

docs: fix minor UX issues on search and links #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 28, 2020

Conversation

heitorlessa
Copy link
Contributor

@heitorlessa heitorlessa commented May 28, 2020

Issue #, if available: #41

Description of changes:

Major fix from this PR has been implemented in DocSearch Algolia: algolia/docsearch-configs#1998

Search results under /api were causing 404, and as we can't have rewrite/redirect in GitHub Pages it's best to update the crawler to prevent that from happening.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@heitorlessa heitorlessa added the documentation Improvements or additions to documentation label May 28, 2020
@heitorlessa heitorlessa self-assigned this May 28, 2020
@heitorlessa heitorlessa merged commit 4b03ddc into aws-powertools:develop May 28, 2020
@heitorlessa heitorlessa deleted the fix/docs-ux branch May 28, 2020 16:36
heitorlessa added a commit that referenced this pull request May 28, 2020
* develop:
  Docs: fix minor UX issues (#42)
  feat: add algolia search for docs and api ref (#39)
@heitorlessa heitorlessa changed the title Docs: fix minor UX issues docs: fix minor UX issues on search and links Jun 3, 2020
heitorlessa referenced this pull request in heitorlessa/aws-lambda-powertools-python Jun 17, 2020
* fix: remove offline plugin #41

Signed-off-by: heitorlessa <[email protected]>

* fix: correct logo link #41

Signed-off-by: heitorlessa <[email protected]>

* fix: search header grey background #41

Signed-off-by: heitorlessa <[email protected]>

* improv: limit docs api dep to speed up CI

Signed-off-by: heitorlessa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant