-
Notifications
You must be signed in to change notification settings - Fork 421
fix(tracer): add name sanitization for X-Ray subsegments #4005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tracer): add name sanitization for X-Ray subsegments #4005
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #4005 +/- ##
===========================================
- Coverage 96.38% 96.30% -0.08%
===========================================
Files 214 215 +1
Lines 10030 10275 +245
Branches 1846 1913 +67
===========================================
+ Hits 9667 9895 +228
- Misses 259 271 +12
- Partials 104 109 +5 ☔ View full report in Codecov by Sentry. |
|
Issue number: #3981
Summary
Changes
This pull request addresses the concern raised by @loesak regarding subsegment names generated when using our Tracer utility. While there's currently no loss of tracer or subsegment data, it's crucial to ensure that the generated names comply with the X-Ray specification to prevent any potential issues or warnings.
User experience
By implementing name sanitization, we'll ensure that X-Ray no longer emits warnings due to non-compliant subsegment names. This bug fix will result in customers no longer receiving X-Ray warnings.
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.