-
Notifications
You must be signed in to change notification settings - Fork 421
feat(event-handler): add compress option when serving Swagger HTML #3946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(event-handler): add compress option when serving Swagger HTML #3946
Conversation
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
hi i didnt add any notes Also looks like sonar is failing with too many parameters for the enable_swagger function. let me know if there is something that you will like me change |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #3946 +/- ##
===========================================
- Coverage 96.38% 96.33% -0.05%
===========================================
Files 214 215 +1
Lines 10030 10251 +221
Branches 1846 1913 +67
===========================================
+ Hits 9667 9875 +208
- Misses 259 269 +10
- Partials 104 107 +3 ☔ View full report in Codecov by Sentry. |
|
@rubenfonseca I need your review here, please. |
Hi @xquek! Yes, Sonar was complaining about too many parameters, but I marked it as "Will not fix" because we have nothing to do. |
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
Issue number: #3935
Summary
Changes
Added option to compress response for swagger UI page.
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
No this is not a breaking change as the default is set to false (current behaviour) **RFC issue number**:Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.