-
Notifications
You must be signed in to change notification settings - Fork 420
feat(event_handler): use custom serializer during openapi serialization #3900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @rubenfonseca! I just left some small suggestions to improve code maintenance and I would like to hear your opinion on the question I asked.
Thanks, Ruben! This is a great improvement.
aws_lambda_powertools/event_handler/middlewares/openapi_validation.py
Outdated
Show resolved
Hide resolved
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
APPROVED!!
Issue number: #3892
Summary
Changes
This PR modifies the OpenAPI validation middleware to use the any custom serialized provided by the user on the event handler, when the normal serialization mechanisms fail.
This allows you to use your own custom serializer when returning custom objects
from the handlers.
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.