Skip to content

fix(event-handler): return dict on missing multi_value_headers #3824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

heitorlessa
Copy link
Contributor

Issue number: #3823

Summary

Addresses regression introduced in 2.33 when running Event Handler APIs locally when multiValueHeaders isn't present.

Changes

Please provide a summary of what's being changed

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@heitorlessa heitorlessa requested a review from a team February 21, 2024 18:23
@boring-cyborg boring-cyborg bot added the tests label Feb 21, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 21, 2024
@github-actions github-actions bot added the bug Something isn't working label Feb 21, 2024
sthulb
sthulb previously approved these changes Feb 21, 2024
@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 21, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
2.1% Duplication on New Code

See analysis details on SonarCloud

@heitorlessa heitorlessa requested a review from sthulb February 21, 2024 18:29
@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e14e768) 96.38% compared to head (c944e3b) 96.42%.
Report is 77 commits behind head on develop.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3824      +/-   ##
===========================================
+ Coverage    96.38%   96.42%   +0.04%     
===========================================
  Files          214      214              
  Lines        10030    10093      +63     
  Branches      1846     1866      +20     
===========================================
+ Hits          9667     9732      +65     
+ Misses         259      258       -1     
+ Partials       104      103       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sthulb sthulb merged commit b89f9ad into aws-powertools:develop Feb 21, 2024
@heitorlessa heitorlessa deleted the fix/event-handler-local-regression branch February 21, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Event Handler Data Validation KeyError: 'multiValueHeaders' regression when running locally
3 participants