-
Notifications
You must be signed in to change notification settings - Fork 420
refactor(feature-flags): add intersection tests; structure refinement #3775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(feature-flags): add intersection tests; structure refinement #3775
Conversation
Signed-off-by: heitorlessa <[email protected]>
Signed-off-by: heitorlessa <[email protected]>
Signed-off-by: heitorlessa <[email protected]>
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #3775 +/- ##
===========================================
+ Coverage 96.38% 96.39% +0.01%
===========================================
Files 214 214
Lines 10030 10102 +72
Branches 1846 1869 +23
===========================================
+ Hits 9667 9738 +71
- Misses 259 260 +1
Partials 104 104 ☔ View full report in Codecov by Sentry. |
Signed-off-by: heitorlessa <[email protected]>
Signed-off-by: heitorlessa <[email protected]>
Leaving these for another two PRs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
had a peer review with @rubenfonseca and will make the following changes before:
- Add debug on
noop
method - Use
cachedproperty
forTimeValues
Leaving to a separate PR
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just left a NP
Co-authored-by: Ruben Fonseca <[email protected]> Signed-off-by: Heitor Lessa <[email protected]>
|
Issue number: #3531
Summary
Adds remaining changes before releasing new intersection rule actions
ANY_IN_VALUE
,ALL_IN_VALUE
,NONE_IN_VALUE
.Changes
ANY_IN_VALUE
ALL_IN_VALUE
NONE_IN_VALUE
context_value
andcondition_value
fn argumentsValueError
for non-list context valueANY_IN_VALUE
ALL_IN_VALUE
NONE_IN_VALUE
Unrelated
lambda
actions on every evaluation call)getattr
)User experience
ALL_IN_VALUE
ANY_IN_VALUE
NONE_IN_VALUE
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.