Skip to content

feat(feature_flags): add intersect actions for conditions #3692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 13, 2024

Conversation

gwlester
Copy link
Contributor

@gwlester gwlester commented Feb 1, 2024

Issue number: #3531

Summary

List intersection action for conditions in feature flags

Changes

Added code to implement and docs -- missing tests.

User experience

Not practical to do.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change? NO

RFC issue number:

Checklist:

  • [ x ] Migration process documented
  • [ x ] Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@gwlester gwlester requested a review from a team February 1, 2024 19:28
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Feb 1, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 1, 2024
@leandrodamascena leandrodamascena linked an issue Feb 1, 2024 that may be closed by this pull request
2 tasks
@leandrodamascena leandrodamascena changed the title Code and docs feat(feature_flags): add intersect actions for conditions Feb 1, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2024

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (e14e768) 96.38% compared to head (68f16b5) 96.15%.
Report is 31 commits behind head on develop.

Files Patch % Lines
..._powertools/utilities/feature_flags/comparators.py 14.28% 24 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3692      +/-   ##
===========================================
- Coverage    96.38%   96.15%   -0.23%     
===========================================
  Files          214      214              
  Lines        10030    10061      +31     
  Branches      1846     1855       +9     
===========================================
+ Hits          9667     9674       +7     
- Misses         259      283      +24     
  Partials       104      104              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leandrodamascena
Copy link
Contributor

Hi @gwlester! Thanks for sending this PR so quickly. The code looks nice at first glance and works for the feature we want. We can optimize some parts, like removing code duplication where we check SchemaValidationError.

Next week we can work together on this PR to add tests and merge it.

Thanks

@gwlester
Copy link
Contributor Author

gwlester commented Feb 1, 2024 via email

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.8% Duplication on New Code

See analysis details on SonarCloud

@sthulb sthulb merged commit f4f9021 into aws-powertools:develop Feb 13, 2024
@gwlester gwlester deleted the feature-3531 branch February 13, 2024 16:32
@heitorlessa
Copy link
Contributor

heitorlessa commented Feb 14, 2024

Commenting so I can look into this before releasing it -- apparently we accidentally merged without confirming docs and tests etc.

Nothing that can't be fixed before release

@heitorlessa heitorlessa added feature New feature or functionality and removed do-not-merge labels Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation feature New feature or functionality size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List intersection action for conditions in feature flags
5 participants