-
Notifications
You must be signed in to change notification settings - Fork 420
feat(feature_flags): add intersect actions for conditions #3692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #3692 +/- ##
===========================================
- Coverage 96.38% 96.15% -0.23%
===========================================
Files 214 214
Lines 10030 10061 +31
Branches 1846 1855 +9
===========================================
+ Hits 9667 9674 +7
- Misses 259 283 +24
Partials 104 104 ☔ View full report in Codecov by Sentry. |
Hi @gwlester! Thanks for sending this PR so quickly. The code looks nice at first glance and works for the feature we want. We can optimize some parts, like removing code duplication where we check SchemaValidationError. Next week we can work together on this PR to add tests and merge it. Thanks |
Sounds good. Sent from my T-Mobile 4G LTE Device
-------- Original message --------From: Leandro Damascena ***@***.***> Date: 2/1/24 16:41 (GMT-06:00) To: aws-powertools/powertools-lambda-python ***@***.***> Cc: Gerald Leter ***@***.***>, Mention ***@***.***> Subject: Re: [aws-powertools/powertools-lambda-python] feat(feature_flags): add intersect actions for conditions (PR #3692)
Hi @gwlester! Thanks for sending this PR so quickly. The code looks nice at first glance and works for the feature we want. We can optimize some parts, like removing code duplication where we check SchemaValidationError.
Next week we can work together on this PR to add tests and merge it.
Thanks
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
Commenting so I can look into this before releasing it -- apparently we accidentally merged without confirming docs and tests etc. Nothing that can't be fixed before release |
Issue number: #3531
Summary
List intersection action for conditions in feature flags
Changes
Added code to implement and docs -- missing tests.
User experience
Not practical to do.
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change? NO
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.